Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed patch for warhammer 40k genes and factions #3522

Conversation

The-Great-Ninth
Copy link
Contributor

@The-Great-Ninth The-Great-Ninth commented Oct 30, 2024

Additions

Describe new functionality added by your code, e.g.
Update for an existing patch for Warhammer 40K Genes and Warhammer 40K Factions. The mod was split into 4 separate modules

Changes

Fixed LoadFolders.xml, changed primarch and custodes GeneDefs since the old genes were replaced by new ones with new GeneDefs

References

Links to the associated issues or other related pull requests, e.g.

Reasoning

Why did you choose to implement things this way, e.g.
Mod author removed his CE patch. Patch allready existed in CE just needed an update

Alternatives

Describe alternative implementations you have considered, e.g.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@The-Great-Ninth The-Great-Ninth requested review from a team as code owners October 30, 2024 17:44
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11598768044.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Oct 30, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11607343450.zip

@N7Huntsman N7Huntsman merged commit 169cdfd into CombatExtended-Continued:Development Oct 31, 2024
3 checks passed
@The-Great-Ninth The-Great-Ninth deleted the Fixed-patch-for-Warhammer-40k-Genes-and-Factions branch November 10, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants