Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate target site for retaliation raids #3528

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

mszabo-wikia
Copy link
Contributor

Changes

Currently, the message that pops up when a retaliation raid is impending does not indicate which world object the raid is targeting, which can be confusing if the player has multiple colonies or launched a bombardment from a temporary map. So, make the target explicit in the notification.

Testing

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony -- tested the retaliation raid notification message from various temp maps (enemy settlement and sun blocker site)

Currently, the message that pops up when a retaliation raid is impending
does not indicate which world object the raid is targeting, which
can be confusing if the player has multiple colonies or launched
a bombardment from a temporary map. So, make the target explicit
in the notification.
@mszabo-wikia mszabo-wikia requested review from a team as code owners November 1, 2024 22:13
Copy link

github-actions bot commented Nov 1, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11637084488.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Nov 1, 2024
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as intended in my testing.

@N7Huntsman N7Huntsman merged commit 64a4b98 into Development Nov 1, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the indicate-retaliation-target branch November 1, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants