Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic mortar shells #3541

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Generic mortar shells #3541

merged 7 commits into from
Nov 21, 2024

Conversation

Safairette
Copy link
Contributor

@Safairette Safairette commented Nov 7, 2024

Additions

  • Mortar shells now support generic ammo mode

Changes

  • Normalized a couple inconsistencies in 155mm howitzer recipes and fixed a typo in 15cm Nebel rockets

References

Balancing atrocities considerations

  • Everything 81mm and below is put into light shells, cost is still based off 81mm
    • Could be slightly reduced to not nerf 60mm shells as hard, but 81mm should still remain the 'default'
  • Both howitzers were put into the heavy category
    • To somewhat normalize the cost disparity the heavy shells still use 155mm costs, but craft 2 at a time like 105mm
    • Not seeing a good way to separate the two without making a separate category just for 155mm
      • 105mm in light shells would create conflicts between the core mortar and guns howitzer using the same shells

Alternatives

  • Rename heavy shells to howitzer shells, since that's all that use it for now

    • I'd probably like that better, but 'heavy' is more of a catch-all term
  • Go with light/medium/heavy categories with 50mm, 60mm/81mm, 105mm/155mm distributions

    • Too granular? Same conflict with 81mm
  • Open to changes, but I expect some cost balancing will have to be sacrificed

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded

@Safairette Safairette requested review from a team as code owners November 7, 2024 17:37
@Safairette Safairette marked this pull request as draft November 7, 2024 17:38
Copy link

github-actions bot commented Nov 7, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11728319030.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Nov 7, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11782770667.zip

@Safairette Safairette marked this pull request as ready for review November 12, 2024 00:06
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11924120970.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11924167083.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11924351645.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11927178845.zip

@sumghai
Copy link
Contributor

sumghai commented Nov 20, 2024

@N7Huntsman - Per your request via Discord, I've fixed the Simplified Mandarin translation for the 15cm Nebelwerfer (HE) rocket crafting recipe to indicate that they are (now) being crafted in batches of 6.

@N7Huntsman N7Huntsman merged commit 20c146b into Development Nov 21, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the generic-mortar-shells branch November 21, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants