Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove redundant partial armor display stat #3545

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Remove redundant partial armor display stat #3545

merged 2 commits into from
Nov 20, 2024

Conversation

N7Huntsman
Copy link
Contributor

Changes

  • Remove the PartialArmorBody stat and the code associated with displaying it, as well as related xml patches and localizations.

Reasoning

  • The stat panel is currently broken, but as best I can tell, it was originally intended to display info for a pawn's partial armor stats. However, that info is now displayed on the same panel as the pawn's actual armor values, rendering it redundant. That being the case, it may as well be removed.

Alternatives

  • Leave it broken.
  • Fix the display panel so it works and remove the stat from other locations.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners November 12, 2024 01:04
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11788767148.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Nov 12, 2024
Thorbane
Thorbane previously approved these changes Nov 12, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11923839816.zip

Airomeda
Airomeda approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@Airomeda Airomeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this will do for now 👍

@N7Huntsman N7Huntsman merged commit 236049c into Development Nov 20, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the ArmorRedundancy branch November 20, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Airomeda Airomeda Airomeda approved these changes

@Thorbane Thorbane Thorbane left review comments

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@N7Huntsman @Thorbane @Airomeda