Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up useStatic tags on Partial Armor #3546

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Nov 12, 2024

Changes

  • Remove all instances of <useStatic>false</useStatic> and add a bit of additional info to the in-line notes.

Reasoning

useStatic is false by default, and so this doesn't need to be specified in the mod extension except in cases where the pawn might be inheriting it from somewhere (there are no such cases in our integrated patches).

I suspect this is simply a case of a value being copy-pasted while patches were being made without people really knowing why. It's functionally harmless, but removing it slightly shortens some file lengths and may reduce confusion as to the field's actual functionality.

Alternatives

  • Leave it as-is.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners November 12, 2024 01:19
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11788915729.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Nov 12, 2024
Copy link
Contributor

@Airomeda Airomeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there won't be any use adding the tag with default value 👍

@N7Huntsman N7Huntsman merged commit 313abf0 into Development Nov 12, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the PartialArmorCleanup branch November 12, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants