Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Housekeeping #3551

Merged
merged 4 commits into from
Nov 16, 2024
Merged

Housekeeping #3551

merged 4 commits into from
Nov 16, 2024

Conversation

N7Huntsman
Copy link
Contributor

@N7Huntsman N7Huntsman commented Nov 15, 2024 •
edited
Loading

Changes

  • Alphabetize some entries in LoadFolders.xml that were just tacked onto the end of the list.
  • Delete empty lines in some xpath patches and in some MakeGunCECompat operations (hopefully this will prevent them propagating).

Reasoning

  • Better to be organized than not.
  • Slightly shorter file length, easier to navigate/read.

Alternatives

  • Could leave it as-is.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long)

@N7Huntsman N7Huntsman requested review from a team as code owners November 15, 2024 03:20
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11849654267.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Nov 15, 2024
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11849709770.zip

Airomeda
Airomeda approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@Airomeda Airomeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks much better 👍

@N7Huntsman N7Huntsman merged commit 547bf00 into Development Nov 16, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the Housekeeping branch November 16, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Airomeda Airomeda Airomeda approved these changes

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@N7Huntsman @Airomeda