Correct Pawn Painshock Threshold Values

[N7Huntsman]

Changes

• Change pain shock threshold of various pawns.
  • Change values of 99 to 0.99, to be more clear.
  • Change values of 90 to 0.90 so that they're actually less than the max threshold.

Reasoning

While PainShockThreshold will accept any numerical value, it is clamped between 0.01 and 0.99 by the StatDef, so only values in that range have any discrete function. All values < 0.01 are functionally the same as 0.01, and all values > 0.99 are functionally the same as 0.99--see the min and max values below.

<StatDef>
    <defName>PainShockThreshold</defName>
    <label>pain shock threshold</label>
    <description>The pain level at which this creature is downed from pain.</description>
    <category>BasicsPawn</category>
    <minValue>0.01</minValue>
    <maxValue>0.99</maxValue>
    <defaultBaseValue>0.8</defaultBaseValue>
    <toStringStyle>PercentZero</toStringStyle>
    <showOnMechanoids>false</showOnMechanoids>
    <displayPriorityInCategory>2000</displayPriorityInCategory>
  </StatDef>

Since several Entities have been assigned a threshold value of 90, there's the distinct impression they were intended to have a lower shock threshold than the Fleshbeasts, which have been set to 99. However, since both these values end up clamped to 0.99, they are mechanically the same in game, making the xml values misleading.

Alternatives

• Leave as-is.

Testing

Check tests you have performed:

• Compiles without warnings
• Game runs without errors
• (For compatibility patches) ...with and without patched mod loaded
• Playtested a colony (about 20 minutes shooting a sightstealer)

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11925502155.zip

[github-actions]

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11925515096.zip

[Airomeda]

Looks more clearer than it was 👍