Remove legacy JobGiver_ConfigurableHostilityResponse #3568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was replaced by a Harmony patch in 2019 (7ea3841), but was later inadvertently added back to compilation after the csproj was overhauled. That in turn broke the Harmony patch because it started targeting the legacy class rather than RimWorld's own vanilla JobGiver_ConfigurableHostilityResponse, causing red errors when a pawn set to attack nearby hostiles automatically had an empty weapon and encountered a hostile pawn.
mszabo-wikia
force-pushed
the
remove-old-jobgiver
branch
from
c2cec6e to
7732197
Compare
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11999703546.zip |
github-actions
bot
added
the
Download in Comments
|
You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-11999712818.zip |
perkinslr
approved these changes
Nov 24, 2024
N7Huntsman
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove the old
JobGiver_ConfigurableHostilityResponseclass, unused since 7ea3841.Reasoning
This was replaced by a Harmony patch in 2019 (7ea3841), but was later inadvertently added back to compilation after the csproj was overhauled. That in turn broke the Harmony patch because it started targeting the legacy class rather than RimWorld's own vanilla JobGiver_ConfigurableHostilityResponse, causing red errors when a pawn set to attack nearby hostiles automatically had an empty weapon and encountered a hostile pawn.
Testing
Check tests you have performed: