Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CompAmmo back to Verb_LaunchProjectileCE #3580

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

mszabo-wikia
Copy link
Contributor

Changes

Add CompAmmo back to Verb_LaunchProjectileCE after it was moved to ShootCE in #3569.

Reasoning

  • Some mods such as Bill Doors' Plasma Weapons will need a recompile before being able to use the new property.

Alternatives

Arrange for dependent mods to recompile against new CE - but there's no guarantee that'll happen in time for the release.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony - tested that plasma weapons work again

Some mods such as Bill Doors' Plasma Weapons will need a recompile
before being able to use the new property.
@mszabo-wikia mszabo-wikia requested review from a team as code owners December 3, 2024 22:38
Copy link

github-actions bot commented Dec 3, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12149370181.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Dec 3, 2024
@N7Huntsman N7Huntsman merged commit 5909d17 into Development Dec 6, 2024
3 checks passed
@N7Huntsman N7Huntsman deleted the fix-compammo branch December 6, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants