Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up various stats #3582

Open
wants to merge 3 commits into
base: Development
Choose a base branch
from
Open

Clean up various stats #3582

wants to merge 3 commits into from

Conversation

Safairette
Copy link
Contributor

Additions

  • Duplicate fire rate and burst shot count stats are hidden on weapons, they were already displayed from verb props.
  • Info tabs of weapons with items without a Thing reference (i.e. from research or crafting screens) now displays bipod stats correctly.
  • Sway and Recoil values on those weapons now also default to 'set up' values, if bipods are enabled.
  • Tweaked the colors of bipod stat explanations to use more muted colors.
  • Added explanation for Night Vision stat calculations.
  • Changed apparel and weapon night vision labels to make the explanation clearer.

Reasoning

  • No point in showing the same data twice.
  • Better to show the stats of the weapon set up, since that's how it's meant to be used.
  • Previous bipod stat colors were too bright.
  • Apparel and weapon night vision stats were impossible to tell apart due to using the same names.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony (specify how long)

@Safairette Safairette requested review from a team as code owners December 4, 2024 22:18
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12169311792.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Dec 4, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12169510481.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 4, 2024

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12169694381.zip

N7Huntsman
N7Huntsman reviewed Dec 5, 2024
View reviewed changes
Languages/English/Keyed/Stats.xml
@@ -9,5 +9,7 @@
<CE_StatsReport_WeaponToughness_StuffEffect>Additional material toughness multiplier:</CE_StatsReport_WeaponToughness_StuffEffect>
<CE_StatsReport_WeaponToughness_HolderEffect>Wielder skill effect:</CE_StatsReport_WeaponToughness_HolderEffect>
<CE_Long_Range_Radio>Long range radio</CE_Long_Range_Radio>
<CE_StatPart_MinimaExplanation>Picks the lowest value of available</CE_StatPart_MinimaExplanation>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What uses/will use these two Keys?

N7Huntsman
N7Huntsman reviewed Dec 5, 2024
View reviewed changes
Defs/Stats/Stats_NightVision.xml
@@ -66,7 +66,7 @@

<StatDef ParentName="EquipmentNightVisionBase">
<defName>NightVisionEfficiency_Weapon</defName>
<label>night vision efficiency</label>
<label>weapon night vision efficiency</label>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to specify in the label? I don't believe it's possible for the various types of night vision efficiencies to appear together on the same panel, is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The stat explanation for the combined night vision stat now displays all 3 sources. And is also where one of the new translation keys is used. The other is on the currently unused statPart that selects the smallest value that's available instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Thoughts on changing the format to night vision efficiency (weapon)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if that's an improvement over the current one, it's probably better when viewed side-by-side like in the screenshot, but I dunno if that's the case for individual items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N7Huntsman N7Huntsman N7Huntsman left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Safairette @N7Huntsman