Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redo 81mm as generic shell #3602

Open
wants to merge 3 commits into
base: Development
Choose a base branch
from
Open

Conversation

Safairette
Copy link
Contributor

@Safairette Safairette commented Dec 20, 2024

Additions

  • Added a new mod extension that can override labels, descriptions and jobStrings for ThingDefs, RecipeDefs and AmmoSetDefs in generic mode, where applicable.
  • Added missing shell translations for Russian translation.

Changes

  • Changed 81mm mortar to act as generic base for other small shells.
  • Removed previous generic shell.
  • Renamed the generic file to fit the changes.

Reasoning

  • There's more hardcoded references than initially expected.
  • A mod extension is still available for patches or translations, as opposed to a conditional patch op.
  • Doesn't separate the ammo data into separate files.

Alternatives

  • Go with conditional patching.
  • Patch more references to fit the 'normal' generic scheme.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • Playtested a colony (specify how long)

@Safairette Safairette requested review from a team as code owners December 20, 2024 18:08
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12436286594.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Dec 20, 2024
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12436318377.zip

Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12458817611.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant