Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Halo UNSC Weapon Pack patch #3632

Merged

Conversation

incorruptable
Copy link
Contributor

Changes

Describe adjustments to existing features made in this merge, e.g.

  • Fixed the Halo UNSC Weapon Patch.
  • Had to adjust the LoadFolders.xml because of it pointing to the wrong mod base (It pointed to a _copy rather than the original. Verified both were meant to be the same mod).
  • Fixed the XML files for the weapon pack. Author of mod being patched changed the defNames on their end. This needed to be reflected in patch file.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors
  • (For compatibility patches) ...with and without patched mod loaded
  • Playtested a colony (specify how long): Two colonies, one lasted 10 days before colonists died and had only CE, the patched mod, and any pre-requisites. Second colony was an already present colony with over 200 other mods to verify consistent operation with other mods/patches. Worked.

@incorruptable incorruptable requested review from a team as code owners January 9, 2025 06:17
Copy link

github-actions bot commented Jan 9, 2025

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12684674323.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jan 9, 2025
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12706511397.zip

@N7Huntsman N7Huntsman changed the title Mod patch Update Halo UNSC Weapon Pack patch Jan 10, 2025
Copy link
Contributor

@N7Huntsman N7Huntsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went ahead and moved the Halo ammo into Defs > Ammo > Modded so that it's better centralized for use across any other halo mods that need it.

Did a bit of housekeeping as well, but didn't find any actual issues in testing. Looks good.

@N7Huntsman N7Huntsman merged commit ca133c8 into CombatExtended-Continued:Development Jan 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants