Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in AmmoInjector #3650

Open
wants to merge 1 commit into
base: Development
Choose a base branch
from
Open

Fix race condition in AmmoInjector #3650

wants to merge 1 commit into from

Conversation

Safairette
Copy link
Contributor

Changes

  • Changed ammoInjector to no longer use a SCOS and only inject ammo with a LongEvent.
  • Added a log to generalizer to more easily check execution order.

Reasoning

  • SCOS was initializing the class earlier than the LongEvent, which led to injection running twice, once in the constructor, and once in said LongEvent.
  • Builds made with the github actions were causing that SCOS to run before the generalizer, causing non-generic hyperlinks to appear in descriptions.

Testing

Check tests you have performed:

  • Compiles without warnings
  • Game runs without errors

@Safairette Safairette requested review from a team as code owners January 15, 2025 23:30
@github-actions GitHub Actions
Copy link

You can download the rebuilt assembly for this PR here: https://combatextended.lp-programming.com/CombatExtended-12798892108.zip

@github-actions github-actions bot added the Download in Comments This PR has a zipfile download available. label Jan 15, 2025
@chief-turkler
Copy link
Contributor

can confirm this fixes the mixed ammo hyperlinks issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Download in Comments This PR has a zipfile download available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Safairette @chief-turkler