SSMprotocol2: Fix VIN validation

Current sanity check fails on newer Outback and Diesel models, causing the software to display the VIN as "not registered yet".
Comer352L · May 26, 2010 · 5cb1c20 · 5cb1c20
1 parent 05f91fb
commit 5cb1c20
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/SSMprotocol2.cpp b/src/SSMprotocol2.cpp
@@ -1871,13 +1871,11 @@ bool SSMprotocol2::validateVIN(char VIN[17])
 	unsigned char k = 0;
 	for (k=0; k<17; k++)
 	{
-		if ((VIN[k] < '\x30') || ((VIN[k] > '\x39') && (VIN[k] < '\x41')) || (VIN[k] > '\x5A'))
-			return false;
-		if ((k==5) || (k==8) || (k>10))
+		if ((VIN[k] < '\x30') || (VIN[k] > '\x39'))	// 0-9
 		{
-			if (VIN[k] > '\x39')
+			if ((k > 10) || (VIN[k] < '\x41') || (VIN[k] > '\x5A')) // A-Z; NOTE: I,O,Q are not allowed
 				return false;
-		}	
+		}
 	}
 	return true;
 }