[lib] Update threads-state-sync-spec to use more general `RawThread…

…Info[s]`

Summary:
Updated types related to thread state sync spec to handle `RawThreadInfo[s]` instead of more specific `LegacyRawThreadInfo[s]`.

---

Depends on D10212

Test Plan: Flow/CI/etc. Will test state sync + set breakpoints to ensure that behavior continues to be as expected.

Reviewers: ashoat, ginsu, tomek, rohan

Reviewed By: rohan

Differential Revision: https://phab.comm.dev/D10223

keyserver/src/shared/state-sync/threads-state-sync-spec.js

@@ -4,8 +4,6 @@ import { rawThreadInfoValidator } from 'lib/permissions/minimally-encoded-thread
 import { threadsStateSyncSpec as libSpec } from 'lib/shared/state-sync/threads-state-sync-spec.js';
 import type { ClientThreadInconsistencyReportCreationRequest } from 'lib/types/report-types.js';
 import {
-  type LegacyRawThreadInfos,
-  type LegacyRawThreadInfo,
   type RawThreadInfo,
   type RawThreadInfos,
 } from 'lib/types/thread-types.js';
@@ -17,9 +15,9 @@ import type { Viewer } from '../../session/viewer.js';
 import { validateOutput } from '../../utils/validation-utils.js';
 
 export const threadsStateSyncSpec: ServerStateSyncSpec<
-  LegacyRawThreadInfos,
-  LegacyRawThreadInfos,
-  LegacyRawThreadInfo,
+  RawThreadInfos,
+  RawThreadInfos,
+  RawThreadInfo,
   $ReadOnlyArray<ClientThreadInconsistencyReportCreationRequest>,
 > = Object.freeze({
   fetch,

lib/shared/state-sync/threads-state-sync-spec.js

@@ -11,8 +11,8 @@ import {
 } from '../../types/report-types.js';
 import type { ProcessServerRequestAction } from '../../types/request-types.js';
 import {
-  type LegacyRawThreadInfos,
-  type LegacyRawThreadInfo,
+  type RawThreadInfo,
+  type RawThreadInfos,
 } from '../../types/thread-types.js';
 import { actionLogger } from '../../utils/action-logger.js';
 import { getConfig } from '../../utils/config.js';
@@ -24,8 +24,8 @@ import { ashoatKeyserverID } from '../../utils/validation-utils.js';
 const selector: (
   state: AppState,
 ) => BoundStateSyncSpec<
-  LegacyRawThreadInfos,
-  LegacyRawThreadInfo,
+  RawThreadInfos,
+  RawThreadInfo,
   $ReadOnlyArray<ClientThreadInconsistencyReportCreationRequest>,
 > = createSelector(
   (state: AppState) => state.integrityStore.threadHashes,
@@ -43,8 +43,8 @@ const selector: (
 );
 
 export const threadsStateSyncSpec: StateSyncSpec<
-  LegacyRawThreadInfos,
-  LegacyRawThreadInfo,
+  RawThreadInfos,
+  RawThreadInfo,
   $ReadOnlyArray<ClientThreadInconsistencyReportCreationRequest>,
 > = Object.freeze({
   hashKey: 'threadInfos',
@@ -55,8 +55,8 @@ export const threadsStateSyncSpec: StateSyncSpec<
   },
   findStoreInconsistencies(
     action: ProcessServerRequestAction,
-    beforeStateCheck: LegacyRawThreadInfos,
-    afterStateCheck: LegacyRawThreadInfos,
+    beforeStateCheck: RawThreadInfos,
+    afterStateCheck: RawThreadInfos,
   ) {
     if (_isEqual(beforeStateCheck)(afterStateCheck)) {
       return emptyArray;

lib/types/report-types.js

@@ -7,7 +7,7 @@ import { type PlatformDetails } from './device-types.js';
 import { type RawEntryInfo, type CalendarQuery } from './entry-types.js';
 import { type MediaMission } from './media-types.js';
 import type { AppState, BaseAction } from './redux-types.js';
-import { type LegacyRawThreadInfos } from './thread-types.js';
+import { type RawThreadInfos } from './thread-types.js';
 import type { UserInfo, UserInfos } from './user-types.js';
 import { tPlatformDetails, tShape } from '../utils/validation-utils.js';
 
@@ -71,10 +71,10 @@ export type ActionSummary = {
 };
 export type ThreadInconsistencyReportShape = {
   +platformDetails: PlatformDetails,
-  +beforeAction: LegacyRawThreadInfos,
+  +beforeAction: RawThreadInfos,
   +action: BaseAction,
-  +pollResult?: ?LegacyRawThreadInfos,
-  +pushResult: LegacyRawThreadInfos,
+  +pollResult?: ?RawThreadInfos,
+  +pushResult: RawThreadInfos,
   +lastActionTypes?: ?$ReadOnlyArray<$PropertyType<BaseAction, 'type'>>,
   +lastActions?: ?$ReadOnlyArray<ActionSummary>,
   +time?: ?number,
@@ -139,9 +139,9 @@ export type ReportCreationRequest =
 
 export type ClientThreadInconsistencyReportShape = {
   +platformDetails: PlatformDetails,
-  +beforeAction: LegacyRawThreadInfos,
+  +beforeAction: RawThreadInfos,
   +action: BaseAction,
-  +pushResult: LegacyRawThreadInfos,
+  +pushResult: RawThreadInfos,
   +lastActions: $ReadOnlyArray<ActionSummary>,
   +time: number,
 };