Skip to content

Commit

Permalink
[native] Fix video in VideoPlaybackModal displayed incorrectly
Browse files Browse the repository at this point in the history
Summary:
https://linear.app/comm/issue/ENG-10078/invalid-video-size-in-videoplaybackmodal-on-android
The screenshot and explanation is included in linear ticket above. Adding `resizeMode` fixed the issue.

Test Plan: Display some videos in `VideoPlaybackModal` on iOS and Android.

Reviewers: bartek, tomek, ashoat

Reviewed By: ashoat

Subscribers: ashoat

Differential Revision: https://phab.comm.dev/D14191
  • Loading branch information
graszka22 committed Jan 13, 2025
1 parent 2c2d193 commit 7f258ae
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions native/media/video-playback-modal.react.js
Original file line number Diff line number Diff line change
Expand Up @@ -725,6 +725,7 @@ function VideoPlaybackModal(props: Props): React.Node {
onProgress={progressCallback}
onEnd={resetVideo}
onReadyForDisplay={readyForDisplayCallback}
resizeMode="contain"
/>
);
}
Expand Down

0 comments on commit 7f258ae

Please sign in to comment.