Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: This diff actually uses the `RadixTree` introduced in the parent diff from the `SearchIndex` code. Linear tasks: [ENG-5137](https://linear.app/comm/issue/ENG-5137/change-searchindex-to-radixtree-or-compressed-trie) and [ENG-5480](https://linear.app/comm/issue/ENG-5480/investigate-chatmentioncontextprovider-tti-regression) Depends on D9626 Test Plan: 1. I tested the chat mentions experience 2. I did some perf testing: In combination with the previous diff, I used [this patch](https://gist.github.com/Ashoat/fc1c91a61009de0e9959527454be8236) to test performance before and after this change. I made sure I had at least three samples of each scenario. Will also link my [messy Gist of results](https://gist.github.com/Ashoat/b871afaaaee10b435b8676175d120d53), but it's not really interpretable by anyone other than me. Here's the relevant portion: ``` BEFORE LOG useChatMentionSearchIndex took 1801ms LOG useChatMentionSearchIndex took 1748ms LOG useChatMentionSearchIndex took 1730ms LOG useChatMentionSearchIndex took 1831ms AVERAGE 1777.5ms JUST DEDUP (parent diff) LOG useChatMentionSearchIndex took 1027ms LOG useChatMentionSearchIndex took 949ms LOG useChatMentionSearchIndex took 957ms AVERAGE 977.7ms DEDUP + RADIX TREE LOG useChatMentionSearchIndex took 643ms LOG useChatMentionSearchIndex took 629ms LOG useChatMentionSearchIndex took 651ms LOG useChatMentionSearchIndex took 609ms AVERAGE 633ms JUST RADIX TREE LOG useChatMentionSearchIndex took 1394ms LOG useChatMentionSearchIndex took 1468ms LOG useChatMentionSearchIndex took 1511ms LOG useChatMentionSearchIndex took 1492ms LOG useChatMentionSearchIndex took 1397ms AVERAGE 1452.4ms ``` Reviewers: tomek, atul, inka, rohan Reviewed By: tomek Subscribers: wyilio Differential Revision: https://phab.comm.dev/D9627
- Loading branch information