-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add ngrok hosting #367
Feature/add ngrok hosting #367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 11 out of 26 changed files in this pull request and generated no comments.
Files not reviewed (15)
- CommunityToolkit.Aspire.sln: Language not supported
- examples/ngrok/CommunityToolkit.Aspire.Hosting.Ngrok.ApiService/CommunityToolkit.Aspire.Hosting.Ngrok.ApiService.csproj: Language not supported
- examples/ngrok/CommunityToolkit.Aspire.Hosting.Ngrok.ApiService/Properties/launchSettings.json: Language not supported
- examples/ngrok/CommunityToolkit.Aspire.Hosting.Ngrok.ApiService/appsettings.json: Language not supported
- examples/ngrok/CommunityToolkit.Aspire.Hosting.Ngrok.AppHost/.gitignore: Language not supported
- examples/ngrok/CommunityToolkit.Aspire.Hosting.Ngrok.AppHost/CommunityToolkit.Aspire.Hosting.Ngrok.AppHost.csproj: Language not supported
- examples/ngrok/CommunityToolkit.Aspire.Hosting.Ngrok.AppHost/Properties/launchSettings.json: Language not supported
- examples/ngrok/CommunityToolkit.Aspire.Hosting.Ngrok.AppHost/appsettings.json: Language not supported
- examples/ngrok/CommunityToolkit.Aspire.Hosting.Ngrok.ServiceDefauls/CommunityToolkit.Aspire.Hosting.Ngrok.ServiceDefauls.csproj: Language not supported
- src/CommunityToolkit.Aspire.Hosting.Ngrok/CommunityToolkit.Aspire.Hosting.Ngrok.csproj: Language not supported
- src/CommunityToolkit.Aspire.Hosting.Ngrok/PublicAPI.Shipped.txt: Language not supported
- src/CommunityToolkit.Aspire.Hosting.Ngrok/PublicAPI.Unshipped.txt: Language not supported
- src/CommunityToolkit.Aspire.Hosting.Ngrok/NgrokResource.cs: Evaluated as low risk
- examples/ngrok/CommunityToolkit.Aspire.Hosting.Ngrok.ApiService/Program.cs: Evaluated as low risk
- examples/ngrok/CommunityToolkit.Aspire.Hosting.Ngrok.AppHost/Program.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/CommunityToolkit.Aspire.Hosting.Ngrok/NgrokEndpoint.cs:4
- The summary comment should be updated to 'Describes an ngrok endpoint.'
/// Describes a ngrok endpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight change for nuget package version management.
Would it be possible to run a proper e2e test, assuming we have a ngrok key that is in the secrets of GitHub Actions? Or would it not be possible to get the ngrok generated URL within the test to then call it?
...ire.Hosting.Ngrok.ServiceDefauls/CommunityToolkit.Aspire.Hosting.Ngrok.ServiceDefauls.csproj
Outdated
Show resolved
Hide resolved
Yes, this would be possible. Is there a naming convention for such secret names? |
Co-authored-by: Aaron Powell <[email protected]>
Hmm, I'm trying to think about how the test would work, it might not be practical though as it could break the local Dev loop (you'd need a token and account configured correctly for tests to pass). Also, the secret wouldn't be available to PR runs, so every PR would have test failures. Might be best to not add that test... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Last question @esskar - are you interested in being the code owner for this integration?
@aaronpowell cool. thanks. If it helps you, i dont mind being a code owner |
Just sent an invite. Can you add this to the
|
Closes ##366
This PR introduces an integration that allows Aspire-hosted applications to leverage ngrok for exposing local services via secure, public URLs.
PR Checklist
Other information