-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RavenDB client & hosting integration #397
Add RavenDB client & hosting integration #397
Conversation
@dotnet-policy-service agree company="Hibernating Rhinos" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 13 out of 28 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- CommunityToolkit.Aspire.sln: Language not supported
- Directory.Packages.props: Language not supported
- examples/ravendb/RavenDB.AppHost/Properties/launchSettings.json: Language not supported
- examples/ravendb/RavenDB.AppHost/RavenDB.AppHost.csproj: Language not supported
- src/CommunityToolkit.Aspire.Hosting.RavenDB/CommunityToolkit.Aspire.Hosting.RavenDB.csproj: Language not supported
- src/CommunityToolkit.Aspire.Hosting.RavenDB/PublicAPI.Shipped.txt: Language not supported
- src/CommunityToolkit.Aspire.Hosting.RavenDB/PublicAPI.Unshipped.txt: Language not supported
- src/CommunityToolkit.Aspire.RavenDB.Client/CommunityToolkit.Aspire.RavenDB.Client.csproj: Language not supported
- src/CommunityToolkit.Aspire.RavenDB.Client/PublicAPI.Shipped.txt: Language not supported
- src/CommunityToolkit.Aspire.RavenDB.Client/PublicAPI.Unshipped.txt: Language not supported
- src/CommunityToolkit.Aspire.Hosting.RavenDB/RavenDBServerSettings.cs: Evaluated as low risk
- src/CommunityToolkit.Aspire.RavenDB.Client/HealthChecksExtensions.cs: Evaluated as low risk
- src/CommunityToolkit.Aspire.RavenDB.Client/README.md: Evaluated as low risk
- src/CommunityToolkit.Aspire.Hosting.RavenDB/README.md: Evaluated as low risk
- src/CommunityToolkit.Aspire.Hosting.RavenDB/RavenDBDatabaseResource.cs: Evaluated as low risk
src/CommunityToolkit.Aspire.Hosting.RavenDB/HealthChecksExtensions.cs
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Aspire.Hosting.RavenDB/HealthChecksExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start and I think the hosting integration is mostly there but we need to do some work on the client integration to align it with the Aspire API design (I've left a comment line on that).
Can we also get the sample expanded so that it includes the client library, even if it's just a serious of API endpoints, so that we have that as a reference point.
src/CommunityToolkit.Aspire.Hosting.RavenDB/CommunityToolkit.Aspire.Hosting.RavenDB.csproj
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Aspire.Hosting.RavenDB/CommunityToolkit.Aspire.Hosting.RavenDB.csproj
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Aspire.RavenDB.Client/RavenDBClientExtension.cs
Outdated
Show resolved
Hide resolved
tests/CommunityToolkit.Aspire.Hosting.RavenDB.Tests/AppHostTests.cs
Outdated
Show resolved
Hide resolved
tests/CommunityToolkit.Aspire.RavenDB.Client.Tests/AspireRavenDBExtensionsTests.cs
Outdated
Show resolved
Hide resolved
tests/CommunityToolkit.Aspire.RavenDB.Client.Tests/AspireRavenDBExtensionsTests.cs
Outdated
Show resolved
Hide resolved
2ff43b5
to
bb74dc7
Compare
@aaronpowell thanks for the feedback! I’ll work on aligning the client integration and I’ll push these updates shortly. |
bb74dc7
to
1a3da1b
Compare
@aaronpowell Client Integration:
Connection String Format:
Expanded Example Code:
Tests:
If you have any additional feedback or suggestions, I’d be happy to address them! |
1a3da1b
to
0596ba8
Compare
Sorry for the delay, I'll hope to review the updates this week |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 19 out of 34 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- CommunityToolkit.Aspire.sln: Language not supported
- Directory.Packages.props: Language not supported
- examples/ravendb/CommunityToolkit.Aspire.Hosting.RavenDB.ApiService/CommunityToolkit.Aspire.Hosting.RavenDB.ApiService.csproj: Language not supported
- examples/ravendb/CommunityToolkit.Aspire.Hosting.RavenDB.ApiService/Properties/launchSettings.json: Language not supported
- examples/ravendb/CommunityToolkit.Aspire.Hosting.RavenDB.ApiService/RavenDB.ApiService.http: Language not supported
- examples/ravendb/CommunityToolkit.Aspire.Hosting.RavenDB.ServiceDefaults/CommunityToolkit.Aspire.Hosting.RavenDB.ServiceDefaults.csproj: Language not supported
- examples/ravendb/RavenDB.AppHost/CommunityToolkit.Aspire.Hosting.RavenDB.AppHost.csproj: Language not supported
- examples/ravendb/RavenDB.AppHost/Properties/launchSettings.json: Language not supported
- src/CommunityToolkit.Aspire.Hosting.RavenDB/CommunityToolkit.Aspire.Hosting.RavenDB.csproj: Language not supported
- src/CommunityToolkit.Aspire.Hosting.RavenDB/PublicAPI.Shipped.txt: Language not supported
- src/CommunityToolkit.Aspire.Hosting.RavenDB/PublicAPI.Unshipped.txt: Language not supported
- src/CommunityToolkit.Aspire.Hosting.RavenDB/HealthChecksExtensions.cs: Evaluated as low risk
- src/CommunityToolkit.Aspire.Hosting.RavenDB/README.md: Evaluated as low risk
- src/CommunityToolkit.Aspire.Hosting.RavenDB/RavenDBBuilderExtensions.cs: Evaluated as low risk
- src/CommunityToolkit.Aspire.Hosting.RavenDB/RavenDBContainerImageTags.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
examples/ravendb/CommunityToolkit.Aspire.Hosting.RavenDB.ApiService/Program.cs:40
- The properties of the 'Company' class should use non-nullable types where possible.
public class Company
Last two things @shiranshalom
Regarding docs, do you want them to be on the RavenDB docs, or is the intent to be on the Microsoft Learn docs? |
- fix client integration - change ConnectionStringExpression format to "URL={Url};Database={DatabaseName}" - expand example to include the client library - fix README.md files - fix and add tests
68c661f
to
bcf3021
Compare
Done
Done
Both! 🙂 I'll be submitting a new PR to the dotnet/docs-aspire repository, and there will also be documentation and articles on our website. I'll share the links as soon as they're available |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good @shiranshalom and I've sent an invite to join the contributors (I thought I'd already done that, whoops!)
Closes #396
This pull request includes several updates to the
Aspire.CommunityToolkit.sln
file, new project additions, and updates to dependencies. The most important changes include the addition of new RavenDB projects, updates to project references, and the introduction of new dependencies.Project Additions and Updates:
Added new RavenDB projects to the solution, including
Aspire.CommunityToolkit.Hosting.RavenDB
,Aspire.CommunityToolkit.RavenDB.Client
, and their respective test and example projects .Dependency Updates:
Added new dependencies in
Directory.Packages.props
, includingRavenDB.Client
,AspNetCore.HealthChecks.RavenDB
, andRavenDB.TestDriver
.PR Checklist
README.md
files for RavenDB client and hosting projects. Complete documentation is prepared, and we will open a PR to the dotnet/docs-aspire repository soon.Other information
We are currently working on an article related to this integration. Once it's ready, I will attach the link here.
Additionally, some links in this PR will need to be updated once the NuGet packages are published.