#240 add papercut smtp hosting #423
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't understand why my PR builds seem to fail often. Any ideas on this? |
|
I found a solution by changing to test against the Papercut Smtp container directly. |
aaronpowell
requested changes
Jan 30, 2025
Comment on lines
2
to
4
| "ConnectionStrings": { | ||
| "papercut": "smpt://xyz:12345" | ||
| }, |
There was a problem hiding this comment.
Should remove this as the integration should add it.
| /// ConnectionString for the Papercut SMTP server in the form of smtp://host:port. | ||
| /// </summary> | ||
| public ReferenceExpression ConnectionStringExpression => ReferenceExpression.Create( | ||
| $"smtp://{SmtpEndpoint.Property(EndpointProperty.Host)}:{SmtpEndpoint.Property(EndpointProperty.Port)}"); |
There was a problem hiding this comment.
For consistency, let's do Endpoint=smtp... and then parse it using the DbConnectionStringBuilder like we do with Ollama
Comment on lines
11
to
23
| /// <summary> | ||
| /// Adds Papercut SMTP to the application model. | ||
| /// </summary> | ||
| /// <param name="builder">The <see cref="IDistributedApplicationBuilder"/> to add the resource to.</param> | ||
| /// <param name="name">The name of the resource.</param> | ||
| /// <remarks> | ||
| /// </remarks> | ||
| /// <returns>A reference to the <see cref="IResourceBuilder{T}"/>.</returns> | ||
| public static IResourceBuilder<PapercutSmtpContainerResource> AddPapercutSmtp(this IDistributedApplicationBuilder builder, | ||
| [ResourceName] string name) | ||
| { | ||
| return builder.AddPapercutSmtp(name, null); | ||
| } |
There was a problem hiding this comment.
This can be removed as the other method provides defaults for httpPort and smtpPort so you can call it without any argument other than name.
src/CommunityToolkit.Aspire.Hosting.PapercutSmtp/PapercutSmtpHostingExtension.cs
Outdated
Show resolved
Hide resolved
tests/CommunityToolkit.Aspire.Hosting.PapercutSmtp.Tests/AppHostTests.cs
Outdated
Show resolved
Hide resolved
tests/CommunityToolkit.Aspire.Hosting.PapercutSmtp.Tests/ContainerResourceCreationTests.cs
Outdated
Show resolved
Hide resolved
anoordover
force-pushed
the
feature/240_Papercut
branch
from
98675ad to
803b914
Compare
|
@aaronpowell thanks for the review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Closes #240 **
PR Checklist
Other information