-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DbGate support for MongoDB #453
Conversation
Running the Postgres-ext example causes multiple DbGate containers to spin up—one for Postgres and another for MongoDB. This occurred because we shared and compiled //The `else` branch will be hit because DbGateContainerResource is not the same.
if (builder.Resources.OfType<DbGateContainerResource>().SingleOrDefault() is { } existingDbGateResource)
{
var builderForExistingResource = builder.CreateResourceBuilder(existingDbGateResource);
return builderForExistingResource;
}
else
{
var dbGateContainer = new DbGateContainerResource(name);
var dbGateContainerBuilder = builder.AddResource(dbGateContainer)
.WithImage(DbGateContainerImageTags.Image, DbGateContainerImageTags.Tag)
.WithImageRegistry(DbGateContainerImageTags.Registry)
.WithHttpEndpoint(targetPort: 3000, port: port, name: DbGateContainerResource.PrimaryEndpointName)
.ExcludeFromManifest();
return dbGateContainerBuilder;
} @aaronpowell, I suggest adding |
Ah yes, that's a really good point. You're right, we're going to need to create that package for the shared types. |
@aaronpowell PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question on the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just provide a mostly empty README since this is a package that isn't really designed for direct consumption?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can not pack the packages with an empty README, but I updated the README to indicate that this package is designed for internal consumption.
Minimum allowed line rate is |
**Contributes to #415 **
PR Checklist
Other information