MarkdownTextBlock: Temporary fix for Fenced code block rendering #595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
|
FYI @nerocui in case you have insights here for the underlying issue. |
|
We talked offline and I'm ok with this change. We should start working on replacing the old MarkdownTextBlock with the new one so that the version conflict of ColorCode goes away. At that point we can revert this PR and uncomment the part that uses ColorCode. |
jcoc611-microsoft
changed the title
Arlodotexe
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily Fixes #547 In CommunityToolkit/Labs-Windows;
once we add the right implementation for FencedCodeBlock, we can bring back the commented code