Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IconTintColorApplyOn #2495

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add IconTintColorApplyOn #2495

wants to merge 2 commits into from

Conversation

TheCodeTraveler
Copy link
Collaborator

Description of Change

Linked Issues

PR Checklist

  • Has a linked Issue, and the Issue has been approved(bug) or Championed (feature/proposal)
  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of main at time of PR
  • Changes adhere to coding standard
  • Documentation created or updated: https://github.com/MicrosoftDocs/CommunityToolkit/pulls

Additional information

@Copilot Copilot bot review requested due to automatic review settings February 4, 2025 23:58
@TheCodeTraveler TheCodeTraveler changed the title Add IconTineColorApplyOn Add IconTintColorApplyOn Feb 4, 2025
Copilot
Copilot AI reviewed Feb 4, 2025
View reviewed changes

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
@TheCodeTraveler TheCodeTraveler added pending documentation This feature requires documentation approved This Proposal has been approved and is ready to be added to the Toolkit labels Feb 5, 2025
@TheCodeTraveler
Copy link
Collaborator Author

TheCodeTraveler commented Feb 5, 2025 •
edited
Loading

Hey @bijington! I've reopened your PR here.

Could you add an implementation of this new feature to the sample app, and open a Docs PR when you get a chance?

And if we can, let's add Unit Tests too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@bijington bijington

Labels
approved This Proposal has been approved and is ready to be added to the Toolkit pending documentation This feature requires documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] IconTintColorBehavior is reset when navigate to another page then back
3 participants
@TheCodeTraveler @bijington @VladislavAntonyuk