-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed failed NuGet validation due to webview2 reference #521
Conversation
Nope, this did not seemingly resolve the issue: @Arlodotexe you want to confirm I put the flag in a good place in the tooling PR? Btw, UWP packages look good now that we have the #490 / #500 regression fixed: |
Looks like it was put in a good place. If this is the correct property, I'm not sure why it'd be failing 🤔 |
Let's try Sergio's comment here, just need to bump the webview2 version in the submodule. |
…ectory conditions
@michael-hawker I've managed to fix the issue. It took a combination of updating WebView2 (as per @Sergio0694's suggestion) and removing both conditions around This seems to have also resolved the issue with the extra |
Mark that as |
FYI @Arlodotexe for CommunityToolkit/Tooling-Windows-Submodule#216 |
Tries to remove extraneous WebView2Loader that was included in WASDK 1.6. If this works we can report back to platform team for proper fix.
Required PR: CommunityToolkit/Tooling-Windows-Submodule#216
Info in CommunityToolkit/Tooling-Windows-Submodule#215