Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ubuntu2404 CIS control 2.3.2.1 #12637

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Update ubuntu2404 CIS control 2.3.2.1 #12637

merged 3 commits into from
Nov 28, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Nov 26, 2024

Description:

  • Add rules and vars for ubuntu2404 CIS control 2.3.2.1 - "Ensure systemd-timesyncd configured with authorized timeserver"
  • Add ubuntu ntp servers to var_multiple_time_servers and var_multiple_time_pools
  • Fix tests for rule service-timesyncd_configured (see commit message for more info)

mpurg added 3 commits November 26, 2024 09:52
@mpurg
Add ubuntu ntp servers
3de3b9a
@mpurg
Update ubuntu2404 CIS control 2.3.2.1
adf8776
@mpurg
Fix tests for service_timesyncd_configured
7777afb 
- define variable var_multiple_time_servers so
  that tests work when the variable is not defined
  by the profile (e.g. when profile is 'all')
- remove test no_fallback.fail.sh as it was not
  aligned with OVAL logic. The test was supposed
  to fail when FallBackNTP was not set, while
  OVAL fails only when neither NTP nor FallBackNTP
  are set. It passes when one of them is set
  correctly. This also agrees with Ubuntu 24.04 CIS
  recommendation 2.3.2.1.
@mpurg mpurg requested a review from a team as a code owner November 26, 2024 08:56
@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 26, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 26, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@dodys dodys self-assigned this Nov 26, 2024
@dodys dodys added Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates. labels Nov 26, 2024
@dodys dodys added this to the 0.1.76 milestone Nov 26, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 26, 2024

Code Climate has analyzed commit 7777afb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

dodys
dodys approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit a6661af into ComplianceAsCode:master Nov 28, 2024
97 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels
needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Milestone
0.1.76
Development

Successfully merging this pull request may close these issues.
2 participants
@mpurg @dodys