Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ubuntu2404 control 2.3.3.1 #12639

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Update ubuntu2404 control 2.3.3.1 #12639

merged 3 commits into from
Nov 28, 2024

Conversation

mpurg
Copy link
Contributor

@mpurg mpurg commented Nov 26, 2024

Description:

  • Added rule and vars for Ubuntu 2404 CIS control 2.3.3.1 - "Ensure chrony is configured with authorized timeserver"
  • Marked as a partial implementation since the rule does not check configs included via confdir and sourcedir directives
  • Fixed the tests

mpurg added 3 commits November 26, 2024 15:38
@mpurg
Add ubuntu ntp servers
3d5a50c
@mpurg
Update ubuntu2404 control 2.3.3.1
6994e17 
Partial implementation of 2.3.3.1 - "Ensure chrony is configured with
authorized timeserver". The rule does not check configs included
via confdir and sourcedir directives.
@mpurg
Fix tests for chronyd_configure_pool_and_server
de97dbb 
- define variables var_multiple_time_servers and var_multiple_time_pools
  so that the tests work when the variables are not defined
  by the profile (e.g. when profile is 'all')
@mpurg mpurg requested a review from a team as a code owner November 26, 2024 14:51
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 26, 2024

Hi @mpurg. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Nov 26, 2024
@github-actions GitHub Actions
Copy link

Start a new ephemeral environment with changes proposed in this pull request:

rhel8 (from CTF) Environment (using Fedora as testing environment)
Open in Gitpod

Fedora Testing Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 26, 2024

Code Climate has analyzed commit de97dbb and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.9% (0.0% change).

View more on Code Climate.

@dodys dodys self-assigned this Nov 28, 2024
@dodys dodys added Ubuntu Ubuntu product related. CIS CIS Benchmark related. labels Nov 28, 2024
@dodys dodys added this to the 0.1.76 milestone Nov 28, 2024
dodys
dodys approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@dodys dodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@dodys dodys merged commit b322223 into ComplianceAsCode:master Nov 28, 2024
91 of 98 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dodys dodys dodys approved these changes

Assignees

@dodys dodys

Labels
CIS CIS Benchmark related. needs-ok-to-test Used by openshift-ci bot. Ubuntu Ubuntu product related.
Projects
None yet
Milestone
0.1.76
Development

Successfully merging this pull request may close these issues.
2 participants
@mpurg @dodys