[Ubuntu2404] Fix remediation of rule accounts_user_dot_group_ownership

[alanmcanonical]

Description:

• Use find instead globbing inside awk
• Change occurrence of uid into gid

Rationale:

• Same as [Ubuntu2404] Fix remediation of rule accounts_user_dot_user_ownership #13026

[openshift-ci]

Hi @alanmcanonical. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[alanmcanonical]

@dodys Please have a look.

[github-actions]

This datastream diff is auto generated by the check Compare DS/Generate Diff

Click here to see the full diff

bash remediation for rule 'xccdf_org.ssgproject.content_rule_accounts_user_dot_group_ownership' differs.
--- xccdf_org.ssgproject.content_rule_accounts_user_dot_group_ownership
+++ xccdf_org.ssgproject.content_rule_accounts_user_dot_group_ownership
@@ -1,2 +1,2 @@
 
-awk -F':' '{ if ($3 >= 1000 && $3 != 65534) system("chgrp -f " $4" "$6"/.[^\.]?*") }' /etc/passwd
+awk -F: '{if ($4 >= 1000 && $4 != 65534) print $4":"$6}' /etc/passwd | while IFS=: read -r gid home; do find "$home" -maxdepth 1 -name "\.[^.]*" -exec chgrp -f $gid "{}" \;; done

ansible remediation for rule 'xccdf_org.ssgproject.content_rule_accounts_user_dot_group_ownership' differs.
--- xccdf_org.ssgproject.content_rule_accounts_user_dot_group_ownership
+++ xccdf_org.ssgproject.content_rule_accounts_user_dot_group_ownership
@@ -1,8 +1,9 @@
 - name: Ensure interactive local users are the group-owners of their respective initialization
     files
-  ansible.builtin.command:
-    cmd: awk -F':' '{ if ($3 >= 1000 && $3 != 65534) system("chgrp -f " $4" "$6"/.[^\.]?*")
-      }' /etc/passwd
+  ansible.builtin.shell:
+    cmd: 'awk -F: ''{if ($4 >= 1000 && $4 != 65534) print $4":"$6}'' /etc/passwd |
+      while IFS=: read -r gid home; do find "$home" -maxdepth 1 -name "\.[^.]*" -exec
+      chgrp -f $gid "{}" \;; done'
   tags:
   - CCE-86314-2
   - accounts_user_dot_group_ownership

[github-actions]

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

[mpurg]

Is there any reason for the ? in the regex? I think it should be \.[^.]*

[alanmcanonical]

You are right.

[github-actions]

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

[github-actions]

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

[github-actions]

Change in Ansible shell module found.

Please consider using more suitable Ansible module than shell if possible.

[codeclimate]

Code Climate has analyzed commit 99d2959 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

[dodys]

@Mab879 @vojtapolasek could youalso take a look on this PR as it will also affect you, specifically the ansible

[dodys]

lgtm, thanks!