Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debian12] Add CIS Benchmark 1.1.0 profiles #13039

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Blasci
Copy link

@Blasci Blasci commented Feb 12, 2025

Description:

Add new profiles for CIS Debian Linux 12 Benchmark 1.1.0 :

  • level 1 server
  • level 2 server
  • level 1 workstation
  • level 2 workstation

#### Rationale:

CIS Debian 12 version 1.1.0 was released in 2024-09-26.

@openshift-ci openshift-ci bot added the needs-ok-to-test Used by openshift-ci bot. label Feb 12, 2025
Copy link

openshift-ci bot commented Feb 12, 2025

Hi @Blasci. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@Mab879 Mab879 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @Blasci!

I have left a few comments. Once you get the new line at the of the file that should help the CI clear up.

products/debian12/profiles/cis_level1_server.profile Outdated Show resolved Hide resolved
products/debian12/profiles/cis_level1_workstation.profile Outdated Show resolved Hide resolved
controls/cis_debian12.yml Show resolved Hide resolved
Copy link

codeclimate bot commented Feb 12, 2025

Code Climate has analyzed commit 5d701f7 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 61.9% (0.0% change).

View more on Code Climate.

@jan-cerny jan-cerny added the Debian Debian product related. label Feb 13, 2025
@Blasci Blasci requested a review from Mab879 February 13, 2025 19:24
@jan-cerny
Copy link
Collaborator

The CI fail on product stability test looks legit. You need to cp build/debian12/product.yml tests/data/product_stability/debian12.yml and then commit changes in tests/data/product_stability/debian12.yml .

@jan-cerny jan-cerny added this to the 0.1.77 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debian Debian product related. needs-ok-to-test Used by openshift-ci bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants