Assets documentation updates, permissionless assets specification, assets CosmWasm interface and clean up of all old things #3777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dzmitry-lahoda <[email protected]>
8 tasks
dzmitry-lahoda
changed the title
dzmitry-lahoda
changed the title
kkast
reviewed
Jul 13, 2023
blasrodri
reviewed
Jul 13, 2023
Signed-off-by: dzmitry-lahoda <[email protected]>
|
@kkast ? |
kkast
approved these changes
Jul 13, 2023
kkast
added a commit
that referenced
this pull request
Jul 20, 2023
…sets CosmWasm interface and clean up of all old things (#3777) - just this one is target for alignment https://github.com/ComposableFi/composable/pull/3777/files#diff-62bb4c85c69a0da7704069fa70b25e210d3ea94c0969a28fab6989f82b78cd54 - added CW interface to assets and generated schema files - delete all legacy/obsolete/incorrect/useless things about assets - delete all in deleting rush because it has assets/tokens in text/name and was obsolete/useless/no compilable/cacneled - fixed nix linter - nuked subquid cc @fl-y - [x] PR title is my best effort to provide summary of changes and has clear text to be part of release notes - [x] I marked PR by `misc` label if it should not be in release notes - [x] I have linked Zenhub/Github or any other reference item if one exists - [x] I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description - [x] I waited and did best effort for `pr-workflow-check / draft-release-check` to finish with success(green check mark) with my changes - [x] I have added at least one reviewer in reviewers list - [x] I tagged(@) or used other form of notification of one person who I think can handle best review of this PR - [x] I have proved that PR has no general regressions of relevant features and processes required to release into production --------- Signed-off-by: dzmitry-lahoda <[email protected]> Co-authored-by: Kostya Kastsevich <[email protected]>
kkast
added a commit
that referenced
this pull request
Jul 20, 2023
…sets CosmWasm interface and clean up of all old things (#3777) - just this one is target for alignment https://github.com/ComposableFi/composable/pull/3777/files#diff-62bb4c85c69a0da7704069fa70b25e210d3ea94c0969a28fab6989f82b78cd54 - added CW interface to assets and generated schema files - delete all legacy/obsolete/incorrect/useless things about assets - delete all in deleting rush because it has assets/tokens in text/name and was obsolete/useless/no compilable/cacneled - fixed nix linter - nuked subquid cc @fl-y - [x] PR title is my best effort to provide summary of changes and has clear text to be part of release notes - [x] I marked PR by `misc` label if it should not be in release notes - [x] I have linked Zenhub/Github or any other reference item if one exists - [x] I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description - [x] I waited and did best effort for `pr-workflow-check / draft-release-check` to finish with success(green check mark) with my changes - [x] I have added at least one reviewer in reviewers list - [x] I tagged(@) or used other form of notification of one person who I think can handle best review of this PR - [x] I have proved that PR has no general regressions of relevant features and processes required to release into production --------- Signed-off-by: dzmitry-lahoda <[email protected]> Co-authored-by: Kostya Kastsevich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just this one is target for alignment https://github.com/ComposableFi/composable/pull/3777/files#diff-62bb4c85c69a0da7704069fa70b25e210d3ea94c0969a28fab6989f82b78cd54
added CW interface to assets and generated schema files
delete all legacy/obsolete/incorrect/useless things about assets
delete all in deleting rush because it has assets/tokens in text/name and was obsolete/useless/no compilable/cacneled
fixed nix linter
nuked subquid cc @fl-y
PR title is my best effort to provide summary of changes and has clear text to be part of release notes
I marked PR by
misclabel if it should not be in release notesI have linked Zenhub/Github or any other reference item if one exists
I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
I waited and did best effort for
pr-workflow-check / draft-release-checkto finish with success(green check mark) with my changesI have added at least one reviewer in reviewers list
I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
I have proved that PR has no general regressions of relevant features and processes required to release into production