sealable-trie: introduce bits::ExtKey type #331
master.yml
on: pull_request
Miscellaneous checks
3m 50s
Build SBF
10m 25s
Rust tests
3m 13s
Rust Miri tests
3m 54s
Annotations
4 errors and 1 warning
Rust tests
Process completed with exit code 101.
|
this expression creates a reference which is immediately dereferenced by the compiler:
common/sealable-trie/src/proof.rs#L170
error: this expression creates a reference which is immediately dereferenced by the compiler
--> common/sealable-trie/src/proof.rs:170:46
|
170 | let ext_key = ExtKey::decode(&key_buf, 0)?;
| ^^^^^^^^ help: change this to: `key_buf`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
= note: `-D clippy::needless-borrow` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_borrow)]`
|
struct `ExtKey` has a public `len` method, but no `is_empty` method:
common/sealable-trie/src/bits/ext_key.rs#L43
error: struct `ExtKey` has a public `len` method, but no `is_empty` method
--> common/sealable-trie/src/bits/ext_key.rs:43:5
|
43 | pub fn len(&self) -> u16 { self.0.len() }
| ^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty
= note: `-D clippy::len-without-is-empty` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::len_without_is_empty)]`
|
Miscellaneous checks
Clippy had exited with the 101 exit code
|
Miscellaneous checks
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|