solana-ibc: store proof of client id together with client state #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we parse client ids we strip out the client type. This means that ‘foo-42’ and ‘bar-42’ are internally represented as 42. To avoid confusion, we keep the client ids in private storage and whenever we index client data by the number we check that the full client id matches. However, that information isn’t currently available in provable storage (i.e. it’s not verifiable by light clients). Change hash we’re storing under client state path to include the client id. This way, light clients will be able to verify that indexes they’re extracting from the client id match the client id they are given. Issue: #35
dhruvja
approved these changes
Nov 20, 2023
blasrodri
approved these changes
Nov 20, 2023
Co-authored-by: Dhruv D Jain <[email protected]> Signed-off-by: Michal Nazarewicz <[email protected]>
Co-authored-by: Dhruv D Jain <[email protected]> Signed-off-by: Michal Nazarewicz <[email protected]>
Co-authored-by: Dhruv D Jain <[email protected]> Signed-off-by: Michal Nazarewicz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we parse client ids we strip out the client type. This means
that ‘foo-42’ and ‘bar-42’ are internally represented as 42. To
avoid confusion, we keep the client ids in private storage and
whenever we index client data by the number we check that the
full client id matches.
However, that information isn’t currently available in provable
storage (i.e. it’s not verifiable by light clients).
Change hash we’re storing under client state path to include the
client id. This way, light clients will be able to verify that
indexes they’re extracting from the client id match the client id
they are given.
Issue: #35