solana-ibc: restrict port identifier and use more compact representation #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restrict port identifier to be 12 alphanumeric characters. With that restriction it’s now possible to decode the port using base64 encoding to get 9 bytes. Those bytes can then serve as an internal port identifier used with the trie and maps in private storage. Issue: #35
blasrodri
approved these changes
Nov 24, 2023
|
This is purely on the implementation side so the same approach works As far as I understand, by introducing this restriction we’re simply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restrict port identifier to be 12 alphanumeric characters. With that
restriction it’s now possible to decode the port using base64 encoding
to get 9 bytes. Those bytes can then serve as an internal port
identifier used with the trie and maps in private storage.
Issue: #35