sealable-trie: add bits::Owned::push and pop_back methods #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mina86
changed the title
Also, for the time being, change bits::Owned::unshift to panic if length of the slice ends up too long. This is consistant with how Vec handles things and in all places where unshift was used the caller unwrapped the value so this isn’t such a terrible design for now.
blasrodri
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, for the time being, change bits::Owned::unshift to panic if
length of the slice ends up too long. This is consistant with how Vec
handles things and in all places where unshift was used the caller
unwrapped the value so this isn’t such a terrible design for now.