-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solana-ibc: update ibc dependency #128
Conversation
I hate that these guys bring breaking changes so often. |
I don’t really mind that much if there’s improvement in the API but this update was a bit annoying indeed. Currently also blocked on informalsystems/ibc-rs#987 |
Hey @dhruvja, @mina86, apologies for any hassle b/c of the recent release. |
Well, it is what it is. I understand need for occasional breaking changes, but that won’t stop me complaining. ;) |
ibc 0.48 restructured the modules hierarchy in quite a big way which
results in noisy diff around imports especially as ibc likes to use
quite long paths. To make this somewhat more bearable, introduce ibc
module with re-exports of IBC types we care about.
Note that 0.48.0 fails to build in no_std on older rustc (which is
what is used with build-spf), thus go straight to 0.48.1 version.