Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solana-ibc: update ibc dependency #128

Merged
merged 10 commits into from
Nov 28, 2023
Merged

solana-ibc: update ibc dependency #128

merged 10 commits into from
Nov 28, 2023

Conversation

mina86
Copy link
Collaborator

@mina86 mina86 commented Nov 25, 2023

ibc 0.48 restructured the modules hierarchy in quite a big way which
results in noisy diff around imports especially as ibc likes to use
quite long paths. To make this somewhat more bearable, introduce ibc
module with re-exports of IBC types we care about.

Note that 0.48.0 fails to build in no_std on older rustc (which is
what is used with build-spf), thus go straight to 0.48.1 version.

@mina86 mina86 requested a review from dhruvja November 25, 2023 01:34
@mina86 mina86 enabled auto-merge (squash) November 25, 2023 01:35
@dhruvja
Copy link
Collaborator

dhruvja commented Nov 25, 2023

I hate that these guys bring breaking changes so often.

@mina86
Copy link
Collaborator Author

mina86 commented Nov 25, 2023

I don’t really mind that much if there’s improvement in the API but this update was a bit annoying indeed. Currently also blocked on informalsystems/ibc-rs#987

@Farhad-Shabani
Copy link

Hey @dhruvja, @mina86, apologies for any hassle b/c of the recent release.
We strive to only change things when it's really essential for supporting a feature or a team's genuine needs. This ibc restructuring was aimed at unlocking diverse teams and use cases. I believe this is also much aligned with what your team requested earlier. By the way, really appreciate your feedback!

@mina86
Copy link
Collaborator Author

mina86 commented Nov 26, 2023

Well, it is what it is. I understand need for occasional breaking changes, but that won’t stop me complaining. ;)

@mina86 mina86 disabled auto-merge November 28, 2023 14:15
@mina86 mina86 enabled auto-merge (squash) November 28, 2023 14:15
@mina86 mina86 merged commit 91c4f63 into master Nov 28, 2023
5 checks passed
@mina86 mina86 deleted the mpn/b branch November 28, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants