Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solana-ibc: avoid unnecessary String allocation in Router impl #39

Merged
merged 2 commits into from
Oct 19, 2023
Merged

solana-ibc: avoid unnecessary String allocation in Router impl #39

merged 2 commits into from
Oct 19, 2023

Conversation

mina86
Copy link
Collaborator

@mina86 mina86 commented Oct 19, 2023

No description provided.

@mina86 mina86 requested a review from dhruvja October 19, 2023 14:37
@mina86 mina86 enabled auto-merge (squash) October 19, 2023 14:37
blasrodri
blasrodri reviewed Oct 19, 2023
View reviewed changes
Copy link
Contributor

@blasrodri blasrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't do .borrow()?

@dhruvja dhruvja disabled auto-merge October 19, 2023 18:35
@dhruvja dhruvja enabled auto-merge (squash) October 19, 2023 18:36
@mina86
Copy link
Collaborator Author

mina86 commented Oct 19, 2023

Fine, have it your way. ;) I was too lazy to use previously.

@dhruvja dhruvja merged commit f276d85 into master Oct 19, 2023
4 checks passed
@dhruvja dhruvja deleted the mpn/c branch October 19, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blasrodri blasrodri blasrodri left review comments

@dhruvja dhruvja dhruvja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mina86 @blasrodri @dhruvja