solana-ibc: encode client state using borsh #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer borsh over JSON since it’s more compact and faster. Since tendermint’s ClientState doesn’t support borsh, use protobuf encoding in the borsh format. Note that protobuf encoding isn’t deterministic which means that the borsh encoding for AnyClientState isn’t deterministic either. Having said that, we should be good so long as clients wanting to verify the value don’t re-encode the borsh-encoded value. Lastly, it’s worth noting that alternatively to using borsh we could use Any protobuf encoding directly. That would be marginally less efficient (since the entire type URL needs to be stored rather than one-byte tag) but it would reduce amount of code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer borsh over JSON since it’s more compact and faster. Since
tendermint’s ClientState doesn’t support borsh, use protobuf encoding
in the borsh format.
Note that protobuf encoding isn’t deterministic which means that the
borsh encoding for AnyClientState isn’t deterministic either. Having
said that, we should be good so long as clients wanting to verify the
value don’t re-encode the borsh-encoded value.
Lastly, it’s worth noting that alternatively to using borsh we could
use Any protobuf encoding directly. That would be marginally less
efficient (since the entire type URL needs to be stored rather than
one-byte tag) but it would reduce amount of code.