solana-ibc: store and read commitments from the trie #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly, since packet and ack commitments are 32-byte long hashes, store them directly in the provable trie rather than storing their hash. Secondly, implement retrieval of the commitments properly. Rather than trying to interpret sequences as commitment, read the hashes from the provable storage. Lastly, get rid of sequence_sets maps in the private store which don’t serve any actual purpose.
|
I think we would also need to store the packet commitments and acks. Something like this for the moment |
|
They are stored in the trie. We don’t need to store them in private storage. |
I thought u were hashing it. If you are just storing it as it is, i can just fetch it from the trie |
dhruvja
approved these changes
Nov 2, 2023
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, since packet and ack commitments are 32-byte long hashes,
store them directly in the provable trie rather than storing their
hash.
Secondly, implement retrieval of the commitments properly. Rather
than trying to interpret sequences as commitment, read the hashes from
the provable storage.
Lastly, get rid of sequence_sets maps in the private store which don’t
serve any actual purpose.