solana-ibc: map IBC client ids into u32 and refactor client state storage #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rage IBC client ids have ‘<client-type>-<counter>’ format where counter is a global sequential number. Take advantage of that by converting client ids into u32 including just the counter. Since we’re effectively ignoring the client-type part of the id, keep counter → client id map in private storage and use it to verify that id we were given is the one we know about. Furthermore, rather than storing client information in a map keep it in a vector which is more compact and faster to index. At the same time, keep just a single vector for all per-client data rather than having separate maps for each piece of information. Issue: #35
blasrodri
reviewed
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IBC client ids have
<client-type>-<counter>format where counter isa global sequential number. Take advantage of that by converting
client ids into u32 including just the counter.
Since we’re effectively ignoring the client-type part of the id, keep
counter → client id map in private storage and use it to verify that
id we were given is the one we know about.
Furthermore, rather than storing client information in a map keep it
in a vector which is more compact and faster to index. At the same
time, keep just a single vector for all per-client data rather than
having separate maps for each piece of information.
Issue: #35