Lint like ibc #293
Closed
Lint like ibc #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@RustNinja please review |
|
Ah @blasrodri that failure is expected. Here let me link you to what I think fixes it... |
|
The above pr fixes the broken test, but not ideally. So it seems like tests were not running consistently and there's a test failure on the west and this results it. I think the issue is the configuration of ICT but I'm not certain about that. |
auto-merge was automatically disabled
December 19, 2023 17:21
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the linter from ibc-go, and makes changes that are oddly similar to some I made to quicksilver lately.