-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rustninja/cosmos eth fees #449
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge-module-added Rustninja/ibctransfer custom ibc transfer module added to store params for eth fees
…om-module-introduced introduced ibc transfer custom module
RustNinja
requested review from
blasrodri,
vmarkushin,
kkast and
dzmitry-lahoda
February 21, 2024 21:50
kkast
suggested changes
Feb 23, 2024
proto/composable/ibctransfermiddleware/v1beta1/ibctransfermiddleware.proto
Outdated
Show resolved
Hide resolved
blasrodri
reviewed
Feb 23, 2024
blasrodri
reviewed
Feb 23, 2024
blasrodri
reviewed
Feb 23, 2024
blasrodri
reviewed
Feb 23, 2024
blasrodri
suggested changes
Feb 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looking good.
- Need tests
- I think there's a bug (that I pointed out)
- clean up
…factoring add docs and fix all requested changes by reviewers
kkast
suggested changes
Feb 28, 2024
…factoring refactoring. Update pr according to requested changes
Did you add tests? |
no. old tested still does not work and not included into github workflow.I jumped to other task that time that have higher priority. |
kkast
approved these changes
Mar 5, 2024
tungleanh0902
pushed a commit
to notional-labs/composable-cosmos
that referenced
this pull request
Mar 7, 2024
…s-eth-fees Rustninja/cosmos eth fees
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced 2 modules:
custom ibc transfer module
custom ibc params module
that store parameters for each channels and allowed tokens with a min fees, percentage + fee account where to send tokensAll fee -> min fee + percentage is going to be send to FeeAddress
If New amount after fee is less or equal 0 then no IBC transfer will happen.
The data structure of params that easy to retrieve by query command
also possible to update via governance proposal with update params message.
Small todo!
Add upgrade handler
depends on the branch from what we are going to release.