Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustninja/cosmos eth fees #449

Merged
merged 20 commits into from
Mar 5, 2024
Merged

Rustninja/cosmos eth fees #449

merged 20 commits into from
Mar 5, 2024

Conversation

RustNinja
Copy link
Collaborator

@RustNinja RustNinja commented Feb 21, 2024

Introduced 2 modules:

  • custom ibc transfer module
  • custom ibc params module that store parameters for each channels and allowed tokens with a min fees, percentage + fee account where to send tokens

All fee -> min fee + percentage is going to be send to FeeAddress
If New amount after fee is less or equal 0 then no IBC transfer will happen.

The data structure of params that easy to retrieve by query command
also possible to update via governance proposal with update params message.

{
   channelFee : {
         Channel: "channel-0",
         FeeAddress : "centauri......."
         AllowedTokens : {
               Percentage : 500, //500 means amount / 500 -> 0.25% from transfer amount
               MinFee : {
                      Denom : "ATOM",
                      Amount : 1000000....
               }
         }
   }
}

Small todo! Add upgrade handler depends on the branch from what we are going to release.

@RustNinja RustNinja changed the base branch from testnetv6_4_4 to develop February 22, 2024 20:31
Copy link

@blasrodri blasrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good.

  • Need tests
  • I think there's a bug (that I pointed out)
  • clean up

@RustNinja RustNinja requested a review from kkast February 27, 2024 20:26
app/keepers/keepers.go Outdated Show resolved Hide resolved
custom/ibc-transfer/keeper/keeper.go Outdated Show resolved Hide resolved
custom/ibc-transfer/module.go Outdated Show resolved Hide resolved
custom/ibc-transfer/module.go Outdated Show resolved Hide resolved
custom/ibc-transfer/module.go Show resolved Hide resolved
x/ibctransfermiddleware/keeper/msg_server.go Show resolved Hide resolved
@RustNinja RustNinja requested a review from kkast March 5, 2024 13:44
@RustNinja RustNinja requested a review from blasrodri March 5, 2024 13:44
@blasrodri
Copy link

Did you add tests?

@RustNinja
Copy link
Collaborator Author

RustNinja commented Mar 5, 2024

Did you add tests?

no. old tested still does not work and not included into github workflow.I jumped to other task that time that have higher priority.

@RustNinja RustNinja merged commit 85e2bf9 into develop Mar 5, 2024
12 of 13 checks passed
tungleanh0902 pushed a commit to notional-labs/composable-cosmos that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants