Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ContainerEnvironmentConfig ResourceId #931

Merged
merged 1 commit into from
May 10, 2022

Conversation

et1975
Copy link
Contributor

@et1975 et1975 commented May 9, 2022

This PR closes ResourceId issue mentioned in #922

The changes in this PR are as follows:

  • ContainerEnvironmentConfig to use managedEnvironments-based ResourceId.

I have read the contributing guidelines and have completed the following:

  • Tested my code end-to-end against a live Azure subscription.
  • Updated the documentation in the docs folder for the affected changes.
  • Written unit tests against the modified code that I have made.
  • Updated the release notes with a new entry for this PR.
  • Checked the coding standards outlined in the contributions guide and ensured my code adheres to them.

If I haven't completed any of the tasks above, I include the reasons why here:
seems pretty straight-forward.

@et1975 et1975 changed the title fix ContainerApps builder ResourceId fix ContainerEnvironmentConfig ResourceId May 9, 2022
@isaacabraham
Copy link
Member

Thanks!

@isaacabraham isaacabraham merged commit 755c5cf into CompositionalIT:master May 10, 2022
@ninjarobot ninjarobot added this to the 1.7.2 milestone May 11, 2022
@ninjarobot
Copy link
Collaborator

Thanks for the contribution, this is included in 1.7.2 and available on nuget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants