This repository has been archived by the owner on Apr 3, 2023. It is now read-only.
SSP Review Feedback for September 2022 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using YAML, we still have to have an array of one item with a scalar. We can still use the special scalar declaration `>-` but need it to be in an array element.
Not 100% clear if this is invalid syntax, but the by-components were double-indented and YAML validators did interpreted this as an embedded closure/block and not more properties of the same statement in the array.
Per our discussion on the topic of generalized and making this MVP, we may want to consider just giving the example app a name and pick yet another random identifier. Leveraging SaaS and information might be a confusing given the simplification of context we want.
aj-stein-nist
force-pushed
the
2-review-ssp
branch
from
346de23 to
1595bc6
Compare
I mean, isn't it?
aj-stein-nist
force-pushed
the
2-review-ssp
branch
from
0e850b7 to
bede99e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback for AJ's review of the sample SSP, closes #2.