Update Schedule.php to exclude holidays from iCal schedules #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes #344
This takes an array of DateTimes that should be excluded from the schedules, like University holidays (calendar link here), and adds it to the generated iCal files so that class events will not be created on those days off. Using the iCal spec EXDATE, we can skip those days and make sure we don't confuse students.
BLOCKERS:
It is up to you to source the array of DateTimes to exclude. I have named the placeholder variable
$holidayTimes, but you must provide the list of dates before this can be merged and implemented.