Escape pipes in tags sent to datadog #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 1, 2017 13:41
datadog splits data from type annotations using a '|' character. Node/express allows pipe characters in routes (regexes). To avoid errors, escape pipe characters before sending statsd data
gmedina
requested changes
Nov 2, 2017
lib/index.js
Outdated
| @@ -9,6 +9,10 @@ module.exports = function (options) { | |||
| let base_url = options.base_url || false; | |||
| let response_code = options.response_code || false; | |||
|
|
|||
| function escapePipes(str) { | |||
| return str.replace(/\|/g, "\\|"); | |||
There was a problem hiding this comment.
since this might get call for every single request, let's declare the regex outside of the function. What do you think? (it is a small performance suggestion).
There was a problem hiding this comment.
also to be super safe, let's make sure str does exist str && str.replace(pattern, '\\|');
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datadog uses pipe characters ("|") to delimit different portions of information in log messages. Unescaped pipes in tag text can cause parsing errors (see AppPress#6)
Escape pipes using regular str.replace