User collection->filter instead of array_filter

ConductionNL · Jan 26, 2024 · 52fcc66 · 52fcc66
1 parent 815bc4d
commit 52fcc66
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/api/src/Security/ApiKeyAuthenticator.php b/api/src/Security/ApiKeyAuthenticator.php
@@ -152,20 +152,22 @@ public function authenticate(Request $request): PassportInterface
         }
 
         try {
-            $user = $application->getOrganization()->getUsers()[0];
+            $user = $application->getOrganization()->getUsers()->first();
 
-            $users = array_filter($application->getOrganization()->getUsers(), function (User $user) {
+            $userCollection = $application->getOrganization()->getUsers();
+            $users = $userCollection->filter(function (User $user) {
                 return $user->getName() === 'APIKEY_USER';
             });
-            if (empty($users[0]) === false) {
-                $user = $users[0];
+
+            if (count($users) > 0) {
+                $user = $users->first();
             }
         } catch (\Exception $exception) {
-            throw new AuthenticationException('An invalid User is configured for this ApiKey');
+            throw new AuthenticationException('An invalid User (or no user) is configured for this ApiKey');
         }
 
         if ($user instanceof User === false) {
-            throw new AuthenticationException('An invalid User is configured for this ApiKey');
+            throw new AuthenticationException('An invalid User (or no user) is configured for this ApiKey');
         }
 
         // Set apiKey Application id in session