No longer use url for sourceId in notifications / syncs when not needed #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smisidjan
previously approved these changes
Jan 23, 2024
Comment on lines
682
to
685
| } else { | ||
| $normalEndpoint = $synchronization->getEndpoint().'/'.$synchronization->getSourceId(); | ||
| $endpoint = str_contains('http', $synchronization->getSourceId()) === true ? $synchronization->getEndpoint() : $normalEndpoint; | ||
| } |
There was a problem hiding this comment.
This can also be a if statement instead of an else.
And try to avoid the if true ? true : false
There was a problem hiding this comment.
I still don't like not using else in some cases like this. Because it results in executing code that gets overwritten immediately, but you are right, codacy wants no else statements or 1 line if statements.
will fix
Comment on lines
1355
to
1358
| } else { | ||
| $normalEndpoint = $synchronization->getEndpoint().($existsInSource ? '/'.$synchronization->getSourceId() : ''); | ||
| $endpoint = str_contains('http', $synchronization->getSourceId()) === true ? $synchronization->getEndpoint() : $normalEndpoint; | ||
| } |
There was a problem hiding this comment.
Same here: This can also be a if statement instead of an else.
rjzondervan
approved these changes
Jan 23, 2024
smisidjan
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.