Merge pull request #172 from ConductionNL/feature/OP-154/downloadCard

feature/OP-154/downloadCard
ConductionNL · Dec 5, 2023 · 4c71379 · 4c71379
2 parents d8cbc00 + 2c584f3
commit 4c71379
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/README.md b/README.md
@@ -4,7 +4,9 @@
 
 - **Version 2.2 (breaking changes from 2.1.x)**
 
-  - 2.2.40: Removed tooltip from PrimaryTopNav component and updated dropdown.
+  - 2.2.40:
+    - Updated DownloadCard to only accept fontawesome icons.
+    - Removed tooltip from PrimaryTopNav component and updated dropdown.
   - 2.2.39:
     - Updated PrimaryTopNav component to include tooltip and better dropdown.
     - Updated Logo component to have navbar option.

diff --git a/src/components/card/downloadCard/DownloadCard.tsx b/src/components/card/downloadCard/DownloadCard.tsx
@@ -5,6 +5,7 @@ import clsx from "clsx";
 import { Heading3, Link } from "@utrecht/component-library-react/dist/css-module";
 import { FontAwesomeIcon } from "@fortawesome/react-fontawesome";
 import {
+  IconDefinition,
   faDatabase,
   faDownload,
   faFileAudio,
@@ -24,7 +25,7 @@ interface DownloadCardProps {
     id: string;
     tooltip: string;
   };
-  icon?: JSX.Element;
+  icon?: IconDefinition;
   layoutClassName?: string;
   handleClick: () => any;
 }
@@ -79,7 +80,7 @@ export const DownloadCard = ({
 
   return (
     <div className={clsx(styles.container, [layoutClassName && layoutClassName])}>
-      <div className={styles.icon}>{icon ?? <FontAwesomeIcon icon={getIconFromType(type)} />}</div>
+      <div className={styles.icon}>{<FontAwesomeIcon icon={icon ?? getIconFromType(type)} />}</div>
       <div className={styles.content}>
         <Heading3
           data-tooltip-id={labelTooltip && labelTooltip.id}