Merge pull request #150 from ConductionNL/development

Dev to master
ConductionNL · Dec 4, 2024 · 078da9f · 078da9f
2 parents a10d8b9 + afd8118
commit 078da9f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/lib/Service/ValidationService.php b/lib/Service/ValidationService.php
@@ -36,7 +36,8 @@ public function __construct(
 	 * Validate a publication to the definition defined in the PublicationType.
 	 *
 	 * @param Publication $publication The publication to validate.
-	 * @return Publication The validated publication.
+	 *
+	 * @return array The validated publication.
 	 *
 	 * @throws DoesNotExistException
 	 * @throws MultipleObjectsReturnedException
@@ -45,6 +46,10 @@ public function __construct(
 	 */
 	public function validatePublication(array $publication): array
 	{
+		if (isset($publication['publicationType']) === false) {
+			return $publication;
+		}
+
 		$publicationTypeId = $publication['publicationType'];
 		$publicationType   = $this->objectService->getObject(objectType: 'publicationType', id: $publicationTypeId);
 

diff --git a/src/views/publications/PublicationDetail.vue b/src/views/publications/PublicationDetail.vue
@@ -329,7 +329,7 @@ import { ref } from 'vue'
 						</div>
 					</BTab>
 					<BTab title="Thema's">
-						<div v-if="filteredThemes?.length">
+						<div v-if="filteredThemes?.length || missingThemes?.length">
 							<NcListItem v-for="(value, key, i) in filteredThemes"
 								:key="`${value.id}${i}`"
 								:name="value.title"
@@ -382,7 +382,7 @@ import { ref } from 'vue'
 								</template>
 							</NcListItem>
 						</div>
-						<div v-if="!filteredThemes?.length" class="tabPanel">
+						<div v-if="!filteredThemes?.length && !missingThemes?.length" class="tabPanel">
 							Geen thema's gevonden
 						</div>
 					</BTab>