Fix conditions check #128
Open
Fix conditions check #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbrands02
commented
Dec 10, 2024
| @@ -5,6 +5,7 @@ | |||
| "sourceId": "1", | |||
| "sourceType": "api", | |||
| "sourceHash": "", | |||
| "sourceHashMapping": "1", | |||
There was a problem hiding this comment.
This field is added in a other pull request but adding it here is harmless
RalkeyOfficial
approved these changes
Dec 12, 2024
| @@ -13,6 +14,7 @@ | |||
| "headers": [], | |||
| "query.startdatum__gte": "2024-08-01", | |||
| "query.einddatum__lt": "2025-01-01", | |||
| "query.maximaleVertrouwelijkheidaanduiding": "openbaar", | |||
There was a problem hiding this comment.
Moet "aanduiding" niet met een hoofdletter?
ik ga ervan uit dat dit met een hoofdletter moet zijn want de andere woorden in deze string hebben ook hoofdletters
There was a problem hiding this comment.
Nee dit is een veld vanuit xxllnc suite, ik heb het niet verzonnen
WilcoLouwerse
requested changes
Dec 12, 2024
| // Take note, JsonLogic::apply() returns a range of return types, so checking it with '=== false' or '!== true' does not work properly. | ||
| if ($synchronization->getConditions() !== [] && !JsonLogic::apply($synchronization->getConditions(), $object)) { | ||
|
|
||
| // @todo log that this object is not valid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.