feature/XW-92/Mobile-Friendly #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lencodes
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Nice changes @remko48.
The only issue I see is that the media queries have to be set manually in each file. Which makes it prone to error (e.g. mobile max-width can be 576px in one file and 567px in the other).
I don't think we can easily fix this, because we're using only css (modules) and not sass. We didn't implement sass two years ago because it would've been a too big of change all at once. However, maybe we should look into doing it now. Can you create a issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on:
ConductionNL/conduction-theme#56